Bug 134257 - [iOS]: WK2 Inspector Node Highlighting
Summary: [iOS]: WK2 Inspector Node Highlighting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-24 11:50 PDT by Joseph Pecoraro
Modified: 2014-06-24 16:50 PDT (History)
10 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (39.89 KB, patch)
2014-06-24 13:15 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (39.96 KB, patch)
2014-06-24 13:29 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Windows Symbol (41.26 KB, patch)
2014-06-24 14:17 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] With New Windows Symbol (41.49 KB, patch)
2014-06-24 14:57 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-06-24 11:50:23 PDT 
Hovering nodes in the inspector is not highlighting them on the page. Inspector node highlighting needs to be hooked up.
Comment 1 Joseph Pecoraro 2014-06-24 13:15:17 PDT 
Created attachment 233732 [details]
[PATCH] Proposed Fix

I decided to do this in the UIProcess so we can keep the CAShapeLayer approach like iOS WK1. Tested iOS WK1 and WK2 and both behave as expected.
Comment 2 Joseph Pecoraro 2014-06-24 13:29:27 PDT 
Created attachment 233735 [details]
[PATCH] Proposed Fix

Rebaselined.
Comment 3 Joseph Pecoraro 2014-06-24 14:17:07 PDT 
Created attachment 233739 [details]
[PATCH] For Windows Symbol

For windows to get new symbol name.
Comment 4 Joseph Pecoraro 2014-06-24 14:57:19 PDT 
Created attachment 233744 [details]
[PATCH] With New Windows Symbol
Comment 5 WebKit Commit Bot 2014-06-24 16:50:38 PDT 
Comment on attachment 233744 [details]
[PATCH] With New Windows Symbol

Clearing flags on attachment: 233744

Committed r170406: <http://trac.webkit.org/changeset/170406>
Comment 6 WebKit Commit Bot 2014-06-24 16:50:43 PDT 
All reviewed patches have been landed.  Closing bug.