Bug 134256 - [ftlopt] StructureAbstractValue::onlyStructure() should return nullptr if isClobbered()
Summary: [ftlopt] StructureAbstractValue::onlyStructure() should return nullptr if isC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-24 11:18 PDT by Filip Pizlo
Modified: 2014-06-24 12:07 PDT (History)
7 users (show)

See Also:

Attachments
the patch (2.13 KB, patch)
2014-06-24 11:20 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-06-24 11:18:51 PDT 
This is a bug, but it's kind of benign right now since none of the optimizations that use onlyStructure() would trigger in regions of code where structures are clobbered.
Comment 1 Filip Pizlo 2014-06-24 11:20:55 PDT 
Created attachment 233721 [details]
the patch
Comment 2 Michael Saboff 2014-06-24 11:27:55 PDT 
Comment on attachment 233721 [details]
the patch

r=me
Comment 3 Filip Pizlo 2014-06-24 12:07:13 PDT 
Landed in http://trac.webkit.org/changeset/170376