r170337 changed return value of TextRun::length from in to unsigned, which caused a warning when comparing two values (int and unsigned) in assertion.
Created attachment 233694 [details] patch
Comment on attachment 233694 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=233694&action=review > Source/WebCore/ChangeLog:3 > + [EFL] Fix debug build I would remove the [EFL] tag as the required code changes are not EFL specific - even only the EFL build is broken. How abut "Fix debug build warnings". Rest looks good. Also can you please put it up for review ?
Comment on attachment 233694 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=233694&action=review >> Source/WebCore/ChangeLog:3 >> + [EFL] Fix debug build > > I would remove the [EFL] tag as the required code changes are not EFL specific - even only the EFL build is broken. How abut "Fix debug build warnings". > > Rest looks good. Also can you please put it up for review ? How about adding "since r170337" too ? "Fix debug build warnings since r170337"
I removed r? flag as r170337 was reverted in <trac.webkit.org/changeset/170360> now, when <http://trac.webkit.org/changeset/170390> has landed I will post the patch again.
Created attachment 233811 [details] fixed changelog
Comment on attachment 233811 [details] fixed changelog LGTM
Comment on attachment 233811 [details] fixed changelog Rejecting attachment 233811 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 233811, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: urce/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp Hunk #1 FAILED at 329. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp.rej patching file Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Gyuyoung Kim']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5659812884905984
Already fixed in <https://trac.webkit.org/changeset/170479>
*** This bug has been marked as a duplicate of bug 134243 ***