Bug 134247 - Fix debug build warnings after r170390
Summary: Fix debug build warnings after r170390
Status: RESOLVED DUPLICATE of bug 134243
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michal Pakula vel Rutka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-24 03:56 PDT by Michal Pakula vel Rutka
Modified: 2014-06-27 07:34 PDT (History)
8 users (show)

See Also:


Attachments
patch (2.48 KB, patch)
2014-06-24 04:57 PDT, Michal Pakula vel Rutka
no flags Details | Formatted Diff | Diff
fixed changelog (2.50 KB, patch)
2014-06-25 07:19 PDT, Michal Pakula vel Rutka
gyuyoung.kim: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2014-06-24 03:56:56 PDT
r170337 changed return value of TextRun::length from in to unsigned, which caused a warning when comparing two values (int and unsigned) in assertion.
Comment 1 Michal Pakula vel Rutka 2014-06-24 04:57:58 PDT
Created attachment 233694 [details]
patch
Comment 2 Laszlo Gombos 2014-06-24 15:21:32 PDT
Comment on attachment 233694 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233694&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] Fix debug build

I would remove the [EFL] tag as the required code changes are not EFL specific - even only the EFL build is broken. How abut "Fix debug build warnings".

Rest looks good. Also can you please put it up for review ?
Comment 3 Gyuyoung Kim 2014-06-24 18:33:16 PDT
Comment on attachment 233694 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233694&action=review

>> Source/WebCore/ChangeLog:3
>> +        [EFL] Fix debug build
> 
> I would remove the [EFL] tag as the required code changes are not EFL specific - even only the EFL build is broken. How abut "Fix debug build warnings".
> 
> Rest looks good. Also can you please put it up for review ?

How about adding "since r170337" too ?

"Fix debug build warnings since r170337"
Comment 4 Michal Pakula vel Rutka 2014-06-25 06:54:54 PDT
I removed r? flag as r170337 was reverted in <trac.webkit.org/changeset/170360> now, when <http://trac.webkit.org/changeset/170390> has landed I will post the patch again.
Comment 5 Michal Pakula vel Rutka 2014-06-25 07:19:02 PDT
Created attachment 233811 [details]
fixed changelog
Comment 6 Gyuyoung Kim 2014-06-26 15:47:33 PDT
Comment on attachment 233811 [details]
fixed changelog

LGTM
Comment 7 WebKit Commit Bot 2014-06-27 02:10:25 PDT
Comment on attachment 233811 [details]
fixed changelog

Rejecting attachment 233811 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 233811, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
urce/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp
Hunk #1 FAILED at 329.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.cpp.rej
patching file Source/WebCore/platform/graphics/harfbuzz/HarfBuzzShaper.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Gyuyoung Kim']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5659812884905984
Comment 8 Michal Pakula vel Rutka 2014-06-27 02:12:49 PDT
Already fixed in <https://trac.webkit.org/changeset/170479>
Comment 9 Michal Pakula vel Rutka 2014-06-27 07:34:08 PDT

*** This bug has been marked as a duplicate of bug 134243 ***