Bug 134241 – Caret positions in ligatures are not placed according to font files' specifications

• Status: NEW
• Component: New Bugs

[Myles C. Maxfield]

Use CTFontGetLigatureCaretPositions to determine where to place the caret in ligatures

[Myles C. Maxfield]

Created attachment 233685 [details]
Needs tests

This patch potentially has devastating performance and memory characteristics. I need to investigate what the hit is.

[Myles C. Maxfield]

The test case I've been using is <span style="font-family: HoeflerText-Regular; font-size: 400px;">filter</span>

[Myles C. Maxfield]

Comment on attachment 233685 [details]
Needs tests

View in context: https://bugs.webkit.org/attachment.cgi?id=233685&action=review

> Source/WebCore/platform/graphics/mac/ComplexTextController.cpp:560
>              } else if (iterationStyle == ByWholeGlyphs) {

On line 553 above there is a comment which is not accurate.

[Myles C. Maxfield]

Created attachment 233774 [details]
Patch

[Myles C. Maxfield]

The characteristics I alluded to above still hold; I still need to do investigation. However, since I added a test, I thought I would still r? this patch so others might comment.

[Build Bot]

Comment on attachment 233774 [details]
Patch

Attachment 233774 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5288568771575808

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233784 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Myles C. Maxfield]

Failure seems to be unrelated

[Myles C. Maxfield]

<rdar://problem/8477480>

[Michael Catanzaro]

Comment on attachment 233774 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.