Bug 134219 - [iOS][WK2] REGRESSION (r169324): Page jumps to top when you type into a text field
Summary: [iOS][WK2] REGRESSION (r169324): Page jumps to top when you type into a text ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-06-23 15:52 PDT by Daniel Bates
Modified: 2014-06-23 21:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2014-06-23 16:01 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-06-23 15:52:15 PDT 
Following the patch for bug #133262, typing into a text field may cause a noticeable jump to the top of the page when the height of the content is equal to the heigh of the visual rectangle.
Comment 1 Daniel Bates 2014-06-23 15:52:43 PDT 
<rdar://problem/17279113>
Comment 2 Daniel Bates 2014-06-23 16:01:11 PDT 
Created attachment 233645 [details]
Patch

I'm not an expert in our scrolling logic. I'm open to suggestions.
Comment 3 Daniel Bates 2014-06-23 16:09:15 PDT 
For completeness, you can observe this regression in a ToT iOS WebKit build as follows:

1. Visit <http://www.twitter.com> and click Sign in.
2. Tap on the Username field to focus it.
3. Tap the > arrow above the keyboard to move the focus to the Password field.
4. Type an arbitrary character, say 'a', into the Password field.

Notice that the scroll view noticeably jumps to the top of the page. Compare this to the behavior in iOS 7.1.1 (11D201).
Comment 4 Benjamin Poulain 2014-06-23 16:36:32 PDT 
Comment on attachment 233645 [details]
Patch

That makes sense, the VisibleContentRect updates definitely drives the scroll position.
Comment 5 Daniel Bates 2014-06-23 21:13:24 PDT 
Comment on attachment 233645 [details]
Patch

Clearing flags on attachment: 233645

Committed r170344: <http://trac.webkit.org/changeset/170344>
Comment 6 Daniel Bates 2014-06-23 21:13:29 PDT 
All reviewed patches have been landed.  Closing bug.