Bug 134216 – Initialize WKWebViewConfiguration media-related properties to their default values.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeremy Jones]

Initialize WKWebViewConfiguration properties to their default values.

[Jeremy Jones]

Created attachment 233639 [details]
Patch

[Jeremy Jones]

<rdar://problem/17308489>

[Anders Carlsson]

Comment on attachment 233639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233639&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:82
> +- (instancetype)init {

Newline before {

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:87
> +    _allowsInlineMediaPlayback = NO;

No need to initialize this, it'll be NO by default.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:91
> +    return self;

I'd add an extra newline here.

[Build Bot]

Comment on attachment 233639 [details]
Patch

Attachment 233639 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4696655706193920

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233649 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Jeremy Jones]

Created attachment 233678 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 233678 [details]
Patch for landing.

Clearing flags on attachment: 233678

Committed r170371: <http://trac.webkit.org/changeset/170371>