Bug 134216 - Initialize WKWebViewConfiguration media-related properties to their default values.
Summary: Initialize WKWebViewConfiguration media-related properties to their default v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-23 15:05 PDT by Jeremy Jones
Modified: 2014-06-24 11:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2014-06-23 15:08 PDT, Jeremy Jones 		andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (510.71 KB, application/zip)
2014-06-23 16:17 PDT, Build Bot 		no flags Details
Patch for landing. (1.62 KB, patch)
2014-06-23 21:15 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-06-23 15:05:54 PDT 
Initialize WKWebViewConfiguration properties to their default values.
Comment 1 Jeremy Jones 2014-06-23 15:08:32 PDT 
Created attachment 233639 [details]
Patch
Comment 2 Jeremy Jones 2014-06-23 15:11:23 PDT 
<rdar://problem/17308489>
Comment 3 Anders Carlsson 2014-06-23 15:43:36 PDT 
Comment on attachment 233639 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233639&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:82
> +- (instancetype)init {

Newline before {

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:87
> +    _allowsInlineMediaPlayback = NO;

No need to initialize this, it'll be NO by default.

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:91
> +    return self;

I'd add an extra newline here.
Comment 4 Build Bot 2014-06-23 16:17:22 PDT 
Comment on attachment 233639 [details]
Patch

Attachment 233639 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4696655706193920

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 5 Build Bot 2014-06-23 16:17:25 PDT 
Created attachment 233649 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Jeremy Jones 2014-06-23 21:15:57 PDT 
Created attachment 233678 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2014-06-24 10:24:42 PDT 
Comment on attachment 233678 [details]
Patch for landing.

Clearing flags on attachment: 233678

Committed r170371: <http://trac.webkit.org/changeset/170371>