Bug 134214 - Don't use the WK prefix for internal C++ types
Summary: Don't use the WK prefix for internal C++ types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-23 14:26 PDT by Anders Carlsson
Modified: 2014-06-23 14:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (36.28 KB, patch)
2014-06-23 14:28 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-06-23 14:26:07 PDT 
Don't use the WK prefix for internal C++ types
Comment 1 Anders Carlsson 2014-06-23 14:28:45 PDT 
Created attachment 233636 [details]
Patch
Comment 2 mitz 2014-06-23 14:30:32 PDT 
Comment on attachment 233636 [details]
Patch

👍
Comment 3 WebKit Commit Bot 2014-06-23 14:31:03 PDT 
Attachment 233636 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/AssistedNodeInformation.h:44:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2014-06-23 14:33:58 PDT 
Committed r170321: <http://trac.webkit.org/changeset/170321>