Bug 134189 – [wk2] Synchronously wait a short time for a layer tree update after bringing a web view in-window

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

So that we don't flash white because of the unparented layer tree.

We can probably short-circuit this sometimes if we have view snapshots, but that is a future optimization.

[Tim Horton]

Created attachment 233589 [details]
patch

[Tim Horton]

This won't apply because it's on top of https://bugs.webkit.org/show_bug.cgi?id=134004

[Simon Fraser (smfr)]

Comment on attachment 233589 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233589&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:327
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(500);

500 vs...

> Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:132
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(250);

250?

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:124
> +        static PassRefPtr<BackingStoreFlusher> create(FlushingContext);

Did you mean to pass by value?

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:320
> +    BackingStoreFlusher::FlushingContext flushingContext;

I can has constructor?

[Tim Horton]

http://trac.webkit.org/changeset/170319

[Radar WebKit Bug Importer]

<rdar://problem/17425232>