Bug 134189 - [wk2] Synchronously wait a short time for a layer tree update after bringing a web view in-window
Summary: [wk2] Synchronously wait a short time for a layer tree update after bringing ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Blocks: 134004
  Show dependency treegraph
Reported: 2014-06-23 02:01 PDT by Tim Horton
Modified: 2014-06-23 14:34 PDT (History)
5 users (show)

See Also:

patch (27.13 KB, patch)
2014-06-23 02:48 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-06-23 02:01:55 PDT
So that we don't flash white because of the unparented layer tree.

We can probably short-circuit this sometimes if we have view snapshots, but that is a future optimization.
Comment 1 Tim Horton 2014-06-23 02:48:15 PDT
Created attachment 233589 [details]
Comment 2 Tim Horton 2014-06-23 12:39:49 PDT
This won't apply because it's on top of https://bugs.webkit.org/show_bug.cgi?id=134004
Comment 3 Simon Fraser (smfr) 2014-06-23 13:53:37 PDT
Comment on attachment 233589 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=233589&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:327
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(500);

500 vs...

> Source/WebKit2/UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:132
> +    auto viewStateUpdateTimeout = std::chrono::milliseconds(250);


> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:124
> +        static PassRefPtr<BackingStoreFlusher> create(FlushingContext);

Did you mean to pass by value?

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:320
> +    BackingStoreFlusher::FlushingContext flushingContext;

I can has constructor?
Comment 4 Tim Horton 2014-06-23 14:33:39 PDT
Comment 5 Radar WebKit Bug Importer 2014-06-23 14:34:38 PDT