Bug 134183 - [iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
Summary: [iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-22 20:59 PDT by Dean Jackson
Modified: 2014-06-23 01:06 PDT (History)
6 users (show)

See Also:


Attachments
Patch (2.28 KB, patch)
2014-06-22 21:02 PDT, Dean Jackson
sam: review+
dino: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-06-22 20:59:08 PDT
[iOS] Use WebGLLayer rather than PlatformLayer in GraphicsContext3D
Comment 1 Dean Jackson 2014-06-22 21:02:29 PDT
Created attachment 233583 [details]
Patch
Comment 2 Sam Weinig 2014-06-22 22:42:35 PDT
Comment on attachment 233583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233583&action=review

> Source/WebCore/ChangeLog:13
> +        * platform/graphics/GraphicsContext3D.h: Replace RefPtr<PlatformLayer>
> +        with RefPtr<WebGLLayer>.

RetainPtr, not RefPtr.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:1010
>  #if PLATFORM(IOS)
>      PlatformGraphicsContext3D m_contextObj;
> -    RetainPtr<PlatformLayer> m_webGLLayer;
> +    RetainPtr<WebGLLayer> m_webGLLayer;
>  #elif PLATFORM(MAC)
>      CGLContextObj m_contextObj;
>      RetainPtr<WebGLLayer> m_webGLLayer;

Can this just be turned into PLATFORM(COCOA)?
Comment 3 Dean Jackson 2014-06-23 01:06:24 PDT
Committed r170285: <http://trac.webkit.org/changeset/170285>