Bug 134181 - [iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snapshot
Summary: [iOS][wk2] Swiping back sometimes results in a missing (not blank) swipe snap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-22 18:14 PDT by Tim Horton
Modified: 2014-06-22 18:32 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.38 KB, patch)
2014-06-22 18:17 PDT, Tim Horton 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-06-22 18:14:12 PDT 
In r170036, I made it so that setRenderTreeSize would remove the snapshot even if m_snapshotRemovalTargetRenderTreeSize wasn't set, so that we would still wait until the first relevant layer tree commit to remove the snapshot. However, this also removed the only guard that ensured that we only removed the snapshot after the swipe was complete; now, any layer tree commit that comes in *during* the swipe will cause the snapshot to be removed. Oops!

Let's make the old behavior more explicit.
Comment 1 Tim Horton 2014-06-22 18:17:13 PDT 
Created attachment 233581 [details]
patch
Comment 2 Radar WebKit Bug Importer 2014-06-22 18:19:57 PDT 
<rdar://problem/17413411>
Comment 3 Benjamin Poulain 2014-06-22 18:23:36 PDT 
Comment on attachment 233581 [details]
patch

Thanks! :)
Comment 4 Tim Horton 2014-06-22 18:32:38 PDT 
http://trac.webkit.org/changeset/170277