RESOLVED FIXED 134179
[Apple] WebGL layer may use GC3D after free with remote layer hosting 
https://bugs.webkit.org/show_bug.cgi?id=134179
Summary [Apple] WebGL layer may use GC3D after free with remote layer hosting
Dean Jackson
Reported 2014-06-22 16:33:17 PDT
[Apple] WebGL layer may use GC3D after free with remote layer hosting
Attachments
Patch (4.47 KB, patch)
2014-06-22 16:40 PDT, Dean Jackson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2014-06-22 16:39:01 PDT
<rdar://problem/17412931>
Dean Jackson
Comment 2 2014-06-22 16:40:48 PDT
Created attachment 233580 [details] Patch
Tim Horton
Comment 3 2014-06-22 16:43:53 PDT
Comment on attachment 233580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335 > + [m_webGLLayer.get() setContext:nullptr]; no .get() required! > Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45 > +@synthesize context=m_context; ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though).
Dean Jackson
Comment 4 2014-06-22 16:45:52 PDT
(In reply to comment #3) > (From update of attachment 233580 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review > > > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335 > > + [m_webGLLayer.get() setContext:nullptr]; > > no .get() required! I was wondering what the approved syntax is here. I wanted to just do .context = nullptr; > > > Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45 > > +@synthesize context=m_context; > > ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though). Yeah, I considered changing that. Since you complained, I'll do it :)
Dean Jackson
Comment 5 2014-06-22 17:00:54 PDT
Committed r170271: <http://trac.webkit.org/changeset/170271>
Note You need to log in before you can comment on or make changes to this bug.