Bug 134179 - [Apple] WebGL layer may use GC3D after free with remote layer hosting
Summary: [Apple] WebGL layer may use GC3D after free with remote layer hosting
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-22 16:33 PDT by Dean Jackson
Modified: 2014-06-22 17:00 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.47 KB, patch)
2014-06-22 16:40 PDT, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-06-22 16:33:17 PDT
[Apple] WebGL layer may use GC3D after free with remote layer hosting
Comment 1 Dean Jackson 2014-06-22 16:39:01 PDT
<rdar://problem/17412931>
Comment 2 Dean Jackson 2014-06-22 16:40:48 PDT
Created attachment 233580 [details]
Patch
Comment 3 Tim Horton 2014-06-22 16:43:53 PDT
Comment on attachment 233580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review

> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335
> +        [m_webGLLayer.get() setContext:nullptr];

no .get() required!

> Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45
> +@synthesize context=m_context;

ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though).
Comment 4 Dean Jackson 2014-06-22 16:45:52 PDT
(In reply to comment #3)
> (From update of attachment 233580 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233580&action=review
> 
> > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:335
> > +        [m_webGLLayer.get() setContext:nullptr];
> 
> no .get() required!

I was wondering what the approved syntax is here. I wanted to just do .context = nullptr;

> 
> > Source/WebCore/platform/graphics/mac/WebGLLayer.mm:45
> > +@synthesize context=m_context;
> 
> ObjC members don't usually have an 'm_' prefix, just '_'. (I see this predates your changes, though).

Yeah, I considered changing that. Since you complained, I'll do it :)
Comment 5 Dean Jackson 2014-06-22 17:00:54 PDT
Committed r170271: <http://trac.webkit.org/changeset/170271>