RESOLVED FIXED 134173
InlineTextBox's m_len can be an unsigned (rather than an unsigned short) 
https://bugs.webkit.org/show_bug.cgi?id=134173
Summary InlineTextBox's m_len can be an unsigned (rather than an unsigned short)
Myles C. Maxfield
Reported 2014-06-22 10:36:41 PDT
Simple line layout alleviates the need for these memory savings.
Attachments
Patch (9.45 KB, patch)
2014-06-23 19:45 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (9.45 KB, patch)
2014-06-23 19:46 PDT, Myles C. Maxfield 		dbates: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-06-23 19:45:37 PDT
Created attachment 233669 [details] Patch
Myles C. Maxfield
Comment 2 2014-06-23 19:46:24 PDT
Comment on attachment 233669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233669&action=review > Source/WebCore/ChangeLog:8 > + After Zalan's talks with Antti, it seems that the simple line layout code Whoops. Looks like this was Kling.
Myles C. Maxfield
Comment 3 2014-06-23 19:46:58 PDT
Created attachment 233670 [details] Patch
Daniel Bates
Comment 4 2014-06-24 12:53:53 PDT
Comment on attachment 233670 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233670&action=review OK > Source/WebCore/rendering/InlineTextBox.h:38 > +const unsigned cNoTruncation = UINT_MAX; > +const unsigned cFullTruncation = UINT_MAX - 1; We should take this opportunity to substitute the C++ idiom of std::numeric_limits<unsigned>::max() for UINT_MAX in these lines.
Myles C. Maxfield
Comment 5 2014-06-24 18:20:16 PDT
http://trac.webkit.org/changeset/170413
Note You need to log in before you can comment on or make changes to this bug.