Bug 134167 - [Bindings] Properties with custom getters or setters should be on the prototypes
Summary: [Bindings] Properties with custom getters or setters should be on the prototypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-21 17:01 PDT by Sam Weinig
Modified: 2017-05-09 15:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.18 KB, patch)
2014-06-21 17:05 PDT, Sam Weinig 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (527.65 KB, application/zip)
2014-06-21 18:42 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (526.93 KB, application/zip)
2014-06-21 19:42 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (569.30 KB, application/zip)
2014-06-22 01:50 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-06-21 17:01:25 PDT 
[Bindings] Properties with custom getters or setters should be on the prototypee
Comment 1 Sam Weinig 2014-06-21 17:05:38 PDT 
Created attachment 233551 [details]
Patch
Comment 2 Build Bot 2014-06-21 18:42:48 PDT 
Comment on attachment 233551 [details]
Patch

Attachment 233551 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4883939390914560

New failing tests:
http/tests/security/xss-DENIED-assign-location-href-javascript.html
http/tests/security/cross-frame-access-enumeration.html
Comment 3 Build Bot 2014-06-21 18:42:51 PDT 
Created attachment 233552 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-06-21 19:42:06 PDT 
Comment on attachment 233551 [details]
Patch

Attachment 233551 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6221067911692288

New failing tests:
http/tests/security/xss-DENIED-assign-location-href-javascript.html
http/tests/security/cross-frame-access-enumeration.html
Comment 5 Build Bot 2014-06-21 19:42:09 PDT 
Created attachment 233553 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-06-22 01:50:39 PDT 
Comment on attachment 233551 [details]
Patch

Attachment 233551 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6247378881347584

New failing tests:
http/tests/security/xss-DENIED-assign-location-href-javascript.html
Comment 7 Build Bot 2014-06-22 01:50:43 PDT 
Created attachment 233562 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Sam Weinig 2017-05-09 15:57:00 PDT 
This was done long ago.