Bug 134165 – Add skeleton code for updated Gamepad API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Add skeleton code for updated Gamepad API

This includes the interfaces for Gamepad, GamepadButton, GamepadEvent, and additions to Navigator.

This is about getting bindings generated and implementation files into the project, and the behavior of these objects will be entirely inert for now.

[Brady Eidson]

Created attachment 233547 [details]
Patch v1

Skeleton idl and implementations for all of the interface additions in the spec.

[Brady Eidson]

Hmmmm EFL has ENABLE_GAMEPAD on, which is wrong.

GTK also seems to have it.

Exploring...

[Brady Eidson]

Created attachment 233548 [details]
Patch v2 - Try to get GTK/EFL builds to not be trying to build this stuff.

[Brady Eidson]

GTK EWS is back to an unrelated failure.
Windows EWS also seems to be unrelated.

EFL is still enabling ENABLE_GAMEPAD for some reason (in addition to the now-deprecated ENABLED_GAMEPAD_DEPRECATED)

Dunno why.

[Sam Weinig]

Comment on attachment 233548 [details]
Patch v2 - Try to get GTK/EFL builds to not be trying to build this stuff.

View in context: https://bugs.webkit.org/attachment.cgi?id=233548&action=review

> Source/WebCore/Modules/gamepad/Gamepad.h:64
> +    Vector<RefPtr<GamepadButton>> m_buttons;

Can this be a Vector<Ref<GamepadButton>>?

> Source/WebCore/Modules/gamepad/Gamepad.idl:27
> +    NoInterfaceObject,

Why NoInterfaceObject?

> Source/WebCore/Modules/gamepad/GamepadButton.idl:27
> +    NoInterfaceObject,

Why NoInterfaceObject?

> Source/WebCore/Modules/gamepad/GamepadEvent.h:40
> +    };

Misplaced ;

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:1613
> -		498770E91242C535002226BA /* Shader.h in Headers */ = {isa = PBXBuildFile; fileRef = 498770D01242C535002226BA /* Shader.h */; };
> +		498770E91242C535002226BA /* (null) in Headers */ = {isa = PBXBuildFile; };

This looks wrong.

[Brady Eidson]

(In reply to comment #5)
> (From update of attachment 233548 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233548&action=review
> 
> > Source/WebCore/Modules/gamepad/Gamepad.h:64
> > +    Vector<RefPtr<GamepadButton>> m_buttons;
> 
> Can this be a Vector<Ref<GamepadButton>>?

Yes.

Doing so requires a const_cast<> in JSDOMBinding.h.  Dunno how you feel about that.


> 
> > Source/WebCore/Modules/gamepad/Gamepad.idl:27
> > +    NoInterfaceObject,
> 
> Why NoInterfaceObject?
> 
> > Source/WebCore/Modules/gamepad/GamepadButton.idl:27
> > +    NoInterfaceObject,
> 
> Why NoInterfaceObject?

My lame copy from the deprecated IDLs that incorrectly have it!


> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:1613
> > -		498770E91242C535002226BA /* Shader.h in Headers */ = {isa = PBXBuildFile; fileRef = 498770D01242C535002226BA /* Shader.h */; };
> > +		498770E91242C535002226BA /* (null) in Headers */ = {isa = PBXBuildFile; };
> 
> This looks wrong.

Yah, weird...  will check on that.  Wasn't explicit on my part!

[Brady Eidson]

Created attachment 233554 [details]
Patch v2

The Shader.h weirdness was because Shader.h was apparently removed from the tree but not from our Xcodeproj.  Apparently the Xcode I'm using really wants to remove it, which seems fine.

[Brady Eidson]

After the patch in 134169 lands, I think I have a patch ready that will also fix the windows build, so we should be good to go

[Brady Eidson]

Created attachment 233559 [details]
Patch v3 - Now with more building?

[Build Bot]

Comment on attachment 233559 [details]
Patch v3 - Now with more building?

Attachment 233559 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5847233958248448

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html

[Build Bot]

Created attachment 233564 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Brady Eidson]

(In reply to comment #10)
> (From update of attachment 233559 [details])
> Attachment 233559 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/5847233958248448
> 
> New failing tests:
> media/W3C/video/src/src_reflects_attribute_not_source_elements.html

This definitely seems unrelated.

[Brady Eidson]

Created attachment 233569 [details]
Patch v4

[Brady Eidson]

Created attachment 233573 [details]
Patch v4 - Take 2 (EFL should work after r170266)

[Build Bot]

Comment on attachment 233573 [details]
Patch v4 - Take 2 (EFL should work after r170266)

Attachment 233573 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5996659653738496

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233576 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Brady Eidson]

(In reply to comment #16)
> Created an attachment (id=233576) [details]
> Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Unlikely the failure is from this patch.

[WebKit Commit Bot]

Comment on attachment 233573 [details]
Patch v4 - Take 2 (EFL should work after r170266)

Clearing flags on attachment: 233573

Committed r170309: <http://trac.webkit.org/changeset/170309>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Brady Eidson]

Forgot to `git commit` Sam's review feedback on one file

Fixed in http://trac.webkit.org/changeset/170314