Bug 134164 - Make it possible to override debug preferences on a per-identifier basis as well as globally
Summary: Make it possible to override debug preferences on a per-identifier basis as w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-21 14:30 PDT by Anders Carlsson
Modified: 2014-06-21 15:02 PDT (History)
0 users

See Also:


Attachments
Patch (14.99 KB, patch)
2014-06-21 14:30 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-06-21 14:30:06 PDT
Make it possible to override debug preferences on a per-identifier basis as well as globally
Comment 1 Anders Carlsson 2014-06-21 14:30:56 PDT
Created attachment 233546 [details]
Patch
Comment 2 mitz 2014-06-21 14:57:19 PDT
Comment on attachment 233546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233546&action=review

> Source/WebKit2/UIProcess/WebPageGroup.cpp:86
> +// FIXME: Why does the WebPreferences object here use â.WebKit2â instead of âWebKit2.â which all the other constructors use.
> +// If it turns out that it's wrong, we can change it to to âWebKit2.â and get rid of the globalDebugKeyPrefix from WebPreferences.

Are we using non-ASCII characters in comments now?

> Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm:121
> +#undef INITIALIZE_PREFERENCE_FROM_NSUSERDEFAULTS

Why is this necessary here?
Comment 3 Anders Carlsson 2014-06-21 15:02:51 PDT
Committed r170253: <http://trac.webkit.org/changeset/170253>