RESOLVED FIXED 134164
Make it possible to override debug preferences on a per-identifier basis as well as globally 
https://bugs.webkit.org/show_bug.cgi?id=134164
Summary Make it possible to override debug preferences on a per-identifier basis as w...
Anders Carlsson
Reported 2014-06-21 14:30:06 PDT
Make it possible to override debug preferences on a per-identifier basis as well as globally
Attachments
Patch (14.99 KB, patch)
2014-06-21 14:30 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2014-06-21 14:30:56 PDT
Created attachment 233546 [details] Patch
mitz
Comment 2 2014-06-21 14:57:19 PDT
Comment on attachment 233546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233546&action=review > Source/WebKit2/UIProcess/WebPageGroup.cpp:86 > +// FIXME: Why does the WebPreferences object here use â.WebKit2â instead of âWebKit2.â which all the other constructors use. > +// If it turns out that it's wrong, we can change it to to âWebKit2.â and get rid of the globalDebugKeyPrefix from WebPreferences. Are we using non-ASCII characters in comments now? > Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm:121 > +#undef INITIALIZE_PREFERENCE_FROM_NSUSERDEFAULTS Why is this necessary here?
Anders Carlsson
Comment 3 2014-06-21 15:02:51 PDT
Committed r170253: <http://trac.webkit.org/changeset/170253>
Note You need to log in before you can comment on or make changes to this bug.