Bug 134163 - Begin work on decoding form data
Summary: Begin work on decoding form data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-21 13:38 PDT by Anders Carlsson
Modified: 2014-06-21 14:02 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.96 KB, patch)
2014-06-21 13:39 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-06-21 13:38:22 PDT 
Begin work on decoding form data
Comment 1 Anders Carlsson 2014-06-21 13:39:21 PDT 
Created attachment 233545 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-21 13:41:17 PDT 
Attachment 233545 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:314:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2014-06-21 13:52:21 PDT 
Comment on attachment 233545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233545&action=review

> Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:316
> +        uint32_t underlyingEnumValue;
> +        *this >> underlyingEnumValue;

Can this use std::underlying_type<>?
Comment 4 Anders Carlsson 2014-06-21 14:01:54 PDT 
Committed r170252: <http://trac.webkit.org/changeset/170252>
Comment 5 Anders Carlsson 2014-06-21 14:02:37 PDT 
(In reply to comment #3)
> (From update of attachment 233545 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=233545&action=review
> 
> > Source/WebKit2/UIProcess/mac/LegacySessionStateCoding.cpp:316
> > +        uint32_t underlyingEnumValue;
> > +        *this >> underlyingEnumValue;
> 
> Can this use std::underlying_type<>?

No, it needs to always use uint32_t.