RESOLVED FIXED 134156
Transition layer offsets from LayoutPoint to LayoutSize. 
https://bugs.webkit.org/show_bug.cgi?id=134156
Summary Transition layer offsets from LayoutPoint to LayoutSize.
zalan
Reported 2014-06-21 09:05:42 PDT
Few RenderLayer functions use LayoutPoint to represent offset values. Use LayoutSize instead.
Attachments
Patch (40.04 KB, patch)
2014-06-21 09:16 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (39.23 KB, patch)
2014-06-22 16:38 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-06-21 09:16:02 PDT
Created attachment 233535 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-06-22 11:14:18 PDT
Comment on attachment 233535 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233535&action=review > Source/WebCore/platform/graphics/LayoutSize.h:195 > +inline FloatSize roundedForPainting(const LayoutSize& size, float pixelSnappingFactor) but...but...how can you snap a size without knowing the location?
zalan
Comment 3 2014-06-22 15:35:52 PDT
(In reply to comment #2) > (From update of attachment 233535 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=233535&action=review > > > Source/WebCore/platform/graphics/LayoutSize.h:195 > > +inline FloatSize roundedForPainting(const LayoutSize& size, float pixelSnappingFactor) > > but...but...how can you snap a size without knowing the location? It's magic! but yea, I should undo this.
zalan
Comment 4 2014-06-22 16:38:49 PDT
Created attachment 233579 [details] Patch
WebKit Commit Bot
Comment 5 2014-06-22 17:34:56 PDT
Comment on attachment 233579 [details] Patch Clearing flags on attachment: 233579 Committed r170273: <http://trac.webkit.org/changeset/170273>
WebKit Commit Bot
Comment 6 2014-06-22 17:35:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.