Commit queue has been failing due to a build failure in WKFoundation.h
Created attachment 233513 [details] Fix CQ build failure
Comment on attachment 233513 [details] Fix CQ build failure View in context: https://bugs.webkit.org/attachment.cgi?id=233513&action=review > Source/WebKit2/ChangeLog:12 > + The availability of this type depends on the version of SDK, > + not the target operating system. The enum is defined using NS_ENUM_AVAILABLE, which in turn uses CF_AVAILABLE: #define CF_AVAILABLE(_mac, _ios) __attribute__((availability(macosx,__NSi_##_mac))) http://opensource.apple.com/source/CF/CF-855.11/CFAvailability.h Enum types defined with by the attribute seems to still exist as a type so re-defining it results in a compilation error.
Comment on attachment 233513 [details] Fix CQ build failure I think that if you want to check the SDK version, you should check if __MAC_OS_X_VERSION_MAX_ALLOWED is defined and is less than 1090.
Created attachment 233514 [details] Fixed per Dan's comment
Created attachment 233515 [details] Use if instead of ifdef
Comment on attachment 233515 [details] Use if instead of ifdef rs=me to unbreak CQ ASAP. Let's see if CQ can land this fix. :)
Okay, it's kind of comedic that we're trying to let the commit queue land this, don't you think? =/
Landed in http://trac.webkit.org/changeset/170237
(In reply to comment #7) > Okay, it's kind of comedic that we're trying to let the commit queue land this, don't you think? =/ Not at all. Commit queue should handle this situation. When the build is broken, CQ can rollout the revision which caused the build breakage. But after a little bit digging, rollout patches are handled specifically, they aren't built and tested at all. Maybe we should teach CQ how to handle quick and important fixes which aren't rollout patches.
Comment on attachment 233515 [details] Use if instead of ifdef removing flags, it was already landed