Bug 134129 - WKThumbnailView should only use live layer trees before the snapshot arrives for parented WKViews
Summary: WKThumbnailView should only use live layer trees before the snapshot arrives ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-20 14:54 PDT by Tim Horton
Modified: 2014-06-20 15:38 PDT (History)
2 users (show)

See Also:


Attachments
patch (2.40 KB, patch)
2014-06-20 15:03 PDT, Tim Horton
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-06-20 14:54:07 PDT
We currently pull the live layer tree into the WKThumbnailView even in snapshot mode, before the snapshot arrives, to avoid flashing when transitioning a live WKView to a thumbnail view. This is, however, not useful for unparented WKViews, because their layer tree will be detached and we'll flash anyway. So, only do that when the WKView is parented.

Also, add a white background so if we don't have a snapshot yet, the thumbnail view isn't transparent.
Comment 1 Tim Horton 2014-06-20 15:03:34 PDT
Created attachment 233461 [details]
patch
Comment 2 Tim Horton 2014-06-20 15:34:33 PDT
<rdar://problem/17401591>
Comment 3 Tim Horton 2014-06-20 15:38:55 PDT
http://trac.webkit.org/changeset/170216