Remove static tables for bindings that use eager reification
Created attachment 233459 [details] Patch
Comment on attachment 233459 [details] Patch Attachment 233459 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5140483131047936 New failing tests: js/dom/webidl-type-mapping.html
Created attachment 233478 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 233459 [details] Patch Attachment 233459 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6407120526245888 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html js/dom/webidl-type-mapping.html
Created attachment 233485 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 233459 [details] Patch This is currently breaking js/dom/webidl-type-mapping.html. Taking a look.
Created attachment 233493 [details] Patch
Attachment 233493 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Structure.h:284: is__proto__ is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 1 in 39 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #6) > (From update of attachment 233459 [details]) > This is currently breaking js/dom/webidl-type-mapping.html. Taking a look. The issue, for those playing along at home, was that when eagerly reifying properties we were not setting the m_hasReadOnlyOrGetterSetterPropertiesExcludingProto bit on the Structure. The reason was that when we do this eager reification, we call JSObject::putDirectCustomAccessor(...) which in turn calls Structure::setHasCustomGetterSetterProperties() (this mirrors the path taken when add a normal getter/setter which calls JSObject::putDirectAccessor(...) which calls Structure::setHasGetterSetterProperties()) but setHasCustomGetterSetterProperties wasn't setting the bit as it should have been. This was not a problem in the past because all use of eager reification had left the static HashTables hanging off their ClassInfo, which initialized the m_hasReadOnlyOrGetterSetterPropertiesExcludingProto bit at Structure creation time.
See also: bug 133687.
Fixed in http://trac.webkit.org/changeset/170256.