Bug 134123 – AX: Remove tight platform expectation coupling form roles-exposed layout test.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Samuel White]

We have some platform specific expectations baked into the roles-exposed.html test that limit our ability to make changes downstream. These type of expectations should be validated via the roles-exposed-expected.txt text diffing (rather than explicit .js checks in the test itself) so we can make platform changes downstream.

[Radar WebKit Bug Importer]

<rdar://problem/17401006>

[Samuel White]

Created attachment 233477 [details]
Patch.

[James Craig]

You might as well pull out the role conditional check and te role description expectations too, no?  It doesn’t make sense to have a PASS notice on the role if the subrole or role description are there but not being used. Just print out the actual results for each.

[Build Bot]

Comment on attachment 233477 [details]
Patch.

Attachment 233477 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6302044176515072

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233496 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Samuel White]

Created attachment 233756 [details]
Patch.

Removing the remaining platform specific information from the test itself and the PASS/FAIL output. Platform agnostic tests such as this one should rely on the text diffs to determine PASS/FAIL.

[Samuel White]

(In reply to comment #3)
> You might as well pull out the role conditional check and te role description expectations too, no?  It doesn’t make sense to have a PASS notice on the role if the subrole or role description are there but not being used. Just print out the actual results for each.

Agreed. Done.

[chris fleizach]

Comment on attachment 233756 [details]
Patch.

gtk will also need to be updated, so please monitor the gtk bot in order to land that result

[WebKit Commit Bot]

Comment on attachment 233756 [details]
Patch.

Clearing flags on attachment: 233756

Committed r170412: <http://trac.webkit.org/changeset/170412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.