Bug 134123 - AX: Remove tight platform expectation coupling form roles-exposed layout test.
Summary: AX: Remove tight platform expectation coupling form roles-exposed layout test.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.9
: P2 Normal
Assignee: Samuel White
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-20 14:30 PDT by Samuel White
Modified: 2014-06-24 17:56 PDT (History)
15 users (show)

See Also:


Attachments
Patch. (1.80 KB, patch)
2014-06-20 16:12 PDT, Samuel White
cfleizach: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (531.60 KB, application/zip)
2014-06-20 18:50 PDT, Build Bot
no flags Details
Patch. (107.88 KB, patch)
2014-06-24 15:56 PDT, Samuel White
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel White 2014-06-20 14:30:05 PDT
We have some platform specific expectations baked into the roles-exposed.html test that limit our ability to make changes downstream. These type of expectations should be validated via the roles-exposed-expected.txt text diffing (rather than explicit .js checks in the test itself) so we can make platform changes downstream.
Comment 1 Radar WebKit Bug Importer 2014-06-20 14:30:16 PDT
<rdar://problem/17401006>
Comment 2 Samuel White 2014-06-20 16:12:55 PDT
Created attachment 233477 [details]
Patch.
Comment 3 James Craig 2014-06-20 18:12:39 PDT
You might as well pull out the role conditional check and te role description expectations too, no?  It doesn’t make sense to have a PASS notice on the role if the subrole or role description are there but not being used. Just print out the actual results for each.
Comment 4 Build Bot 2014-06-20 18:50:37 PDT
Comment on attachment 233477 [details]
Patch.

Attachment 233477 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6302044176515072

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 5 Build Bot 2014-06-20 18:50:40 PDT
Created attachment 233496 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Samuel White 2014-06-24 15:56:41 PDT
Created attachment 233756 [details]
Patch.

Removing the remaining platform specific information from the test itself and the PASS/FAIL output. Platform agnostic tests such as this one should rely on the text diffs to determine PASS/FAIL.
Comment 7 Samuel White 2014-06-24 16:01:41 PDT
(In reply to comment #3)
> You might as well pull out the role conditional check and te role description expectations too, no?  It doesn’t make sense to have a PASS notice on the role if the subrole or role description are there but not being used. Just print out the actual results for each.

Agreed. Done.
Comment 8 chris fleizach 2014-06-24 16:59:57 PDT
Comment on attachment 233756 [details]
Patch.

gtk will also need to be updated, so please monitor the gtk bot in order to land that result
Comment 9 WebKit Commit Bot 2014-06-24 17:56:42 PDT
Comment on attachment 233756 [details]
Patch.

Clearing flags on attachment: 233756

Committed r170412: <http://trac.webkit.org/changeset/170412>
Comment 10 WebKit Commit Bot 2014-06-24 17:56:48 PDT
All reviewed patches have been landed.  Closing bug.