Bug 134121 – [New Multicolumn] Writing mode and direction of flow thread can mismatch enclosing paginated RenderView

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

When a document propagates a writing mode change or direction change up to the view, we don't properly update the writing-mode and direction of column sets or flow thread if the view is paginated.

[Dave Hyatt]

Created attachment 233452 [details]
Patch

[WebKit Commit Bot]

Attachment 233452 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBox.cpp:401:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/RenderBox.cpp:401:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBox.cpp:402:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBox.cpp:403:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 233617 [details]
Patch

[WebKit Commit Bot]

Attachment 233617 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:1977:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:1978:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:1979:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

Comment on attachment 233617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233617&action=review

> Source/WebCore/rendering/RenderBox.cpp:372
> +        RenderObject* rootRenderer = isBodyRenderer ? document().documentElement()->renderer() : nullptr;

Slightly risky that someone will move rootRenderer outside the isBodyRenderer blocks below, but hopefully no one will be that careless ($10 that it will be me in 4 years time).

[Dave Hyatt]

Fix landed in r170304.