Bug 134116 – HTMLMediaElement seek algorithm should allow cancelling previous seeks.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

HTMLMediaElement seek algorithm should allow cancelling previous seeks.

[Jer Noble]

Created attachment 233454 [details]
Patch

[WebKit Commit Bot]

Attachment 233454 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:429:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Created attachment 233455 [details]
Patch

[WebKit Commit Bot]

Attachment 233455 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:432:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Comment on attachment 233455 [details]
Patch

> Source/WebCore/html/HTMLMediaElement.h:736
> +    std::unique_ptr<PendingSeek> m_pendingSeek;

Since there can only be one of these, why not have "PendingSeek m_pendingSeek" so it doesn't need to be allocated each time?

[Jer Noble]

Comment on attachment 233455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233455&action=review

>> Source/WebCore/html/HTMLMediaElement.h:736
>> +    std::unique_ptr<PendingSeek> m_pendingSeek;
> 
> Since there can only be one of these, why not have "PendingSeek m_pendingSeek" so it doesn't need to be allocated each time?

Because there needs to be a way to distinguish between "I have a pending seek" and "I have no pending seeks". Otherwise, the ASSERT() in seekTimerFired wouldn't catch when an unexpected seek happened.

[Build Bot]

Comment on attachment 233455 [details]
Patch

Attachment 233455 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6109625321521152

New failing tests:
media/video-seek-with-negative-playback.html
media/video-currentTime-set2.html
media/media-controller-playbackrate.html
media/video-played-ranges-1.html
media/video-fast-seek.html
media/video-ended-event-negative-playback.html

[Build Bot]

Created attachment 233474 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 233455 [details]
Patch

Attachment 233455 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5091649352892416

New failing tests:
media/video-seek-with-negative-playback.html
media/video-currentTime-set2.html
media/media-controller-playbackrate.html
media/video-played-ranges-1.html
media/video-fast-seek.html
media/video-ended-event-negative-playback.html

[Build Bot]

Created attachment 233479 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 233455 [details]
Patch

Attachment 233455 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4552547230547968

New failing tests:
media/video-seek-with-negative-playback.html
media/video-currentTime-set2.html
media/media-controller-playbackrate.html
media/video-played-ranges-1.html
media/video-fast-seek.html
media/video-ended-event-negative-playback.html

[Build Bot]

Created attachment 233516 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Jer Noble]

Created attachment 233629 [details]
Patch for landing.

[Build Bot]

Comment on attachment 233629 [details]
Patch for landing.

Attachment 233629 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6743095953588224

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233638 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Jer Noble]

Committed r170336: <http://trac.webkit.org/changeset/170336>

[Csaba Osztrogonác]

(In reply to comment #16)
> Committed r170336: <http://trac.webkit.org/changeset/170336>

It made fullscreen/video-cursor-auto-hide.html crash on the Apple Mac bots.

[Simon Fraser (smfr)]

This caused a new assertion: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK1%20(Tests)/r170338%20(6081)/fullscreen/video-cursor-auto-hide-crash-log.txt

[Simon Fraser (smfr)]

... which is a crash in release:
http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r170361%20(6882)/fullscreen/video-cursor-auto-hide-crash-log.txt

[Jer Noble]

Tracking the crash in <https://bugs.webkit.org/show_bug.cgi?id=134253>