Bug 134104 - CallbackMap::put should be able to take an unwrapped function
Summary: CallbackMap::put should be able to take an unwrapped function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-20 07:14 PDT by mitz
Modified: 2014-06-21 15:26 PDT (History)
2 users (show)

See Also:


Attachments
Overload CallbackMap::put (14.24 KB, patch)
2014-06-20 07:16 PDT, mitz
no flags Details | Formatted Diff | Diff
Overload CallbackMap::put (14.23 KB, patch)
2014-06-21 13:15 PDT, mitz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-20 07:14:50 PDT
Make it possible to pass an unwrapped function to CallbackMap::put
Comment 1 mitz 2014-06-20 07:16:55 PDT
Created attachment 233426 [details]
Overload CallbackMap::put
Comment 2 WebKit Commit Bot 2014-06-20 07:19:01 PDT
Attachment 233426 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/GenericCallback.h:190:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-06-21 13:15:01 PDT
Created attachment 233544 [details]
Overload CallbackMap::put
Comment 4 WebKit Commit Bot 2014-06-21 13:16:31 PDT
Attachment 233544 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/GenericCallback.h:190:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 mitz 2014-06-21 15:26:13 PDT
Committed <http://trac.webkit.org/r170254>.