Bug 134096 – [EFL] Remove the WebKit1 EFL code

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

rm -rf Source/WebKit/efl

[Ryuan Choi]

Created attachment 233412 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 233412 [details]
Patch

rs=me

[Ryuan Choi]

Created attachment 233416 [details]
Patch

Added one missing file

[WebKit Commit Bot]

Comment on attachment 233416 [details]
Patch

Rejecting attachment 233416 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 233416, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 = self._filesystem.open_text_file_for_reading(self.path)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 204, in open_text_file_for_reading
    return codecs.open(path, 'r', 'utf8', errors)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 881, in open
    file = __builtin__.open(filename, mode, buffering)
IOError: [Errno 2] No such file or directory: u'/Volumes/Data/EWS/WebKit/Source/WebKit/efl/ChangeLog'

Full output: http://webkit-queues.appspot.com/results/6170918799802368

[Ryuan Choi]

(In reply to comment #4)
> (From update of attachment 233416 [details])
> Rejecting attachment 233416 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 233416, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> Last 500 characters of output:
>  = self._filesystem.open_text_file_for_reading(self.path)
>   File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 204, in open_text_file_for_reading
>     return codecs.open(path, 'r', 'utf8', errors)
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 881, in open
>     file = __builtin__.open(filename, mode, buffering)
> IOError: [Errno 2] No such file or directory: u'/Volumes/Data/EWS/WebKit/Source/WebKit/efl/ChangeLog'
> 
> Full output: http://webkit-queues.appspot.com/results/6170918799802368

Hmm, it looks that modified_changelogs() in checkout.py does not consider whether changelog is deleted or not.

I am not sure how I can land this before fixing Tools.

Below is the log when I used direct-land. ( ./Tools/Scripts/webkit-patch land-attachment 233416 [details] )

Can't open /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/ChangeLog at /home/ryuan/workspace/project/webkit/efl-webkit/Tools/Scripts/commit-log-editor line 221.
Failed to run "[u'/home/ryuan/workspace/project/webkit/efl-webkit/Tools/Scripts/commit-log-editor', '--print-log', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/ChangeLog', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/ChangeLog']" exit_code: 2
Failed to run "[u'/home/ryuan/workspace/project/webkit/efl-webkit/Tools/Scripts/commit-log-editor', '--print-log', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/ChangeLog', u'/home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit/efl/ChangeLog']" exit_code: 2

[Csaba Osztrogonác]

Landed in https://trac.webkit.org/changeset/170289 manually, git svn dcommit 
is our friends when webkit-patch land can't handle something. ;)

[Ryuan Choi]

(In reply to comment #6)
> Landed in https://trac.webkit.org/changeset/170289 manually, git svn dcommit 
> is our friends when webkit-patch land can't handle something. ;)

Thanks. :)