Bug 134093 - [EFL][CMAKE] Disable WebKit1 build as a default
Summary: [EFL][CMAKE] Disable WebKit1 build as a default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks: 134087
  Show dependency tree / graph
 
Reported: 2014-06-19 23:15 PDT by Ryuan Choi
Modified: 2014-06-19 23:52 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.69 KB, patch)
2014-06-19 23:20 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-06-19 23:15:42 PDT 
SSIA
Comment 1 Ryuan Choi 2014-06-19 23:20:09 PDT 
Created attachment 233408 [details]
Patch
Comment 2 Gyuyoung Kim 2014-06-19 23:36:21 PDT 
Comment on attachment 233408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233408&action=review

r=me except for my questions.

> Source/cmake/OptionsEfl.cmake:8
> +set(ENABLE_WEBKIT OFF)

Should we keep this flag ?

> Tools/CMakeLists.txt:10
>      add_subdirectory(DumpRenderTree/TestNetscapePlugIn)

ditto
Comment 3 Ryuan Choi 2014-06-19 23:52:35 PDT 
Comment on attachment 233408 [details]
Patch

Clearing flags on attachment: 233408

Committed r170175: <http://trac.webkit.org/changeset/170175>
Comment 4 Ryuan Choi 2014-06-19 23:52:44 PDT 
All reviewed patches have been landed.  Closing bug.