Bug 134085 - [iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
Summary: [iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks M...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-19 17:53 PDT by Simon Fraser (smfr)
Modified: 2014-06-20 12:22 PDT (History)
9 users (show)

See Also:

Attachments
Patch (67.75 KB, patch)
2014-06-19 19:26 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (31.56 KB, patch)
2014-06-20 11:14 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-06-19 17:53:32 PDT 
[iOS WebKit2] Make -webkit-overflow-scrolling:touch work in iframes (breaks MSWord previews)
Comment 1 Simon Fraser (smfr) 2014-06-19 19:26:08 PDT 
Created attachment 233401 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-06-20 11:14:06 PDT 
Created attachment 233435 [details]
Patch
Comment 3 Tim Horton 2014-06-20 11:31:00 PDT 
Comment on attachment 233435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233435&action=review

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:109
> +            switch (nodeType) {

this looks ripe for moving into another function, and factoring the appendChild out, and just cleaning up in general

> Source/WebCore/page/scrolling/ScrollingStateTree.h:85
> +    enum SubframeNodeRemoval {

enum class? and drop the "SubframeNodes" suffix? SubframeNodeRemoval::Delete, SubframeNodeRemoval::Orphan, etc.
Comment 4 Simon Fraser (smfr) 2014-06-20 12:22:21 PDT 
https://trac.webkit.org/r170198