Bug 134073 - Unfreeze the layer tree on DidFirstVisuallyNonEmptyLayout
Summary: Unfreeze the layer tree on DidFirstVisuallyNonEmptyLayout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 134097
Blocks:
  Show dependency tree / graph
 
Reported: 2014-06-19 13:58 PDT by Antti Koivisto
Modified: 2014-06-20 01:04 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.72 KB, patch)
2014-06-19 14:05 PDT, Antti Koivisto 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-06-19 13:58:12 PDT 
DidFirstLayout is too early and we usually get a blank page. This doesn't match existing iOS behavior either.
Comment 1 Antti Koivisto 2014-06-19 14:01:48 PDT 
<rdar://problem/17383962>
Comment 2 Antti Koivisto 2014-06-19 14:05:03 PDT 
Created attachment 233381 [details]
patch
Comment 3 Simon Fraser (smfr) 2014-06-19 14:09:56 PDT 
Comment on attachment 233381 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233381&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:577
> +        if (m_frame == m_frame->page()->mainWebFrame()) {

.isMainFrame()?

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:580
> +                m_didCompletePageTransitionAlready = true;

The "Already" here seems superfluous.
Comment 4 Antti Koivisto 2014-06-19 15:16:04 PDT 
http://trac.webkit.org/changeset/170163
Comment 5 Zsolt Borbely 2014-06-20 01:04:33 PDT 
It made all performance tests crash on EFL, here is the new bug
report about is: https://bugs.webkit.org/show_bug.cgi?id=134097
Have you got any idea what happened?