Bug 134068 - Web Inspector: Esc in quick console no longer toggles console drawer
Summary: Web Inspector: Esc in quick console no longer toggles console drawer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-19 12:18 PDT by Joseph Pecoraro
Modified: 2014-06-21 07:51 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.19 KB, patch)
2014-06-19 14:27 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-06-19 12:18:03 PDT 
Regression. Pushing Esc in the quick console no longer toggles the console drawer. It should!
Comment 1 Joseph Pecoraro 2014-06-19 12:59:51 PDT 
This appears to be a CodeMirror 4 regression, because CodeMirror now has a basic keymap for "Esc".
Comment 2 Radar WebKit Bug Importer 2014-06-19 13:01:04 PDT 
<rdar://problem/17382967>
Comment 3 Joseph Pecoraro 2014-06-19 13:02:09 PDT 
In CodeMirror 4 with multiple selection:

    Esc - singleSelection
    When multiple selections are present, this deselects all but the primary selection.
Comment 4 Joseph Pecoraro 2014-06-19 13:09:01 PDT 
Maybe, CodeMirror should only prevent default if it actually did something.

In any case we may be able to workaround this because we only want to toggle the console when there is no text.
Comment 5 Joseph Pecoraro 2014-06-19 14:27:32 PDT 
This was annoying me quite a bit, so I made a workaround. I think we should still go through and suggest a code mirror change to only prevent default if an action was taken (if multiple selections were collapsed to one).
Comment 6 Joseph Pecoraro 2014-06-19 14:27:48 PDT 
Created attachment 233383 [details]
[PATCH] Proposed Fix
Comment 7 Timothy Hatcher 2014-06-19 14:30:23 PDT 
Comment on attachment 233383 [details]
[PATCH] Proposed Fix

Looks good! I agree that CodeMirror should pass on the key if it doesn't do anything.
Comment 8 WebKit Commit Bot 2014-06-21 07:51:43 PDT 
Comment on attachment 233383 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 233383

Committed r170238: <http://trac.webkit.org/changeset/170238>
Comment 9 WebKit Commit Bot 2014-06-21 07:51:46 PDT 
All reviewed patches have been landed.  Closing bug.