RESOLVED FIXED 134068
Web Inspector: Esc in quick console no longer toggles console drawer 
https://bugs.webkit.org/show_bug.cgi?id=134068
Summary Web Inspector: Esc in quick console no longer toggles console drawer
Joseph Pecoraro
Reported 2014-06-19 12:18:03 PDT
Regression. Pushing Esc in the quick console no longer toggles the console drawer. It should!
Attachments
[PATCH] Proposed Fix (4.19 KB, patch)
2014-06-19 14:27 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-06-19 12:59:51 PDT
This appears to be a CodeMirror 4 regression, because CodeMirror now has a basic keymap for "Esc".
Radar WebKit Bug Importer
Comment 2 2014-06-19 13:01:04 PDT
<rdar://problem/17382967>
Joseph Pecoraro
Comment 3 2014-06-19 13:02:09 PDT
In CodeMirror 4 with multiple selection: Esc - singleSelection When multiple selections are present, this deselects all but the primary selection.
Joseph Pecoraro
Comment 4 2014-06-19 13:09:01 PDT
Maybe, CodeMirror should only prevent default if it actually did something. In any case we may be able to workaround this because we only want to toggle the console when there is no text.
Joseph Pecoraro
Comment 5 2014-06-19 14:27:32 PDT
This was annoying me quite a bit, so I made a workaround. I think we should still go through and suggest a code mirror change to only prevent default if an action was taken (if multiple selections were collapsed to one).
Joseph Pecoraro
Comment 6 2014-06-19 14:27:48 PDT
Created attachment 233383 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 7 2014-06-19 14:30:23 PDT
Comment on attachment 233383 [details] [PATCH] Proposed Fix Looks good! I agree that CodeMirror should pass on the key if it doesn't do anything.
WebKit Commit Bot
Comment 8 2014-06-21 07:51:43 PDT
Comment on attachment 233383 [details] [PATCH] Proposed Fix Clearing flags on attachment: 233383 Committed r170238: <http://trac.webkit.org/changeset/170238>
WebKit Commit Bot
Comment 9 2014-06-21 07:51:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.