Bug 134059 – REGRESSION (r168685): css calc() expression fails

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[hooleyhoop]

This expression no longer works..

width: calc((100% - 20px) / 3;

equivalent expression still works

width: calc(100%/3 - 20px/3)

[Simon Fraser (smfr)]

Regressed in http://trac.webkit.org/changeset/168685.

[Radar WebKit Bug Importer]

<rdar://problem/17431912>

[Simon Fraser (smfr)]

Martin, can you take a look please, so we don't have to roll out your patch?

[[e-mail]]

Yes, I am already working on it, I just need a little more time.
I will upload a patch till tomorrow.

[[e-mail]]

I have reverted my repository to the revision before right my patch (r168684) and it does not work either.
This expression can not be parsed properly because of the superfluous '(' character, but seems like it is
an older issue. () However, I am glad to investigate it.

The following example shows two rectangle of the same size:
<div width="300px">
  <div style="height:100px; width: calc((100% - 20px) / 3); border: 1px solid;" ></div>
  <div style="height:100px; width: calc(100%/3 - 20px/3); border: 1px solid;"></div>
</div>

[Simon Fraser (smfr)]

The test case def. worked in http://trac.webkit.org/changeset/168684

[Martin Hodovan]

(In reply to comment #0)
> This expression no longer works..
> 
> width: calc((100% - 20px) / 3;

I think there has been some misunderstanding here. Your first example is a malformed expression,
because a closing brace is missing from the end, and therefore it can not be parsed properly.
I thought that my patch has ruined some error recovery feature, which seemed a little unlikely,
since my patch did not change the CSS grammar. So I double-checked it and the expression you
mentioned has never worked before. (Maybe I should report it, if it needs auto-correction at all.)

But now I get it. "width: calc((100% - 20px) / 3)" is now a well-formed expression and it really
does not work since my patch has landed. Thank you for your patience, I will upload a fix very soon.

[Martin Hodovan]

Created attachment 233987 [details]
Proposed patch

[WebKit Commit Bot]

Comment on attachment 233987 [details]
Proposed patch

Clearing flags on attachment: 233987

Committed r170544: <http://trac.webkit.org/changeset/170544>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.