Bug 134058 - [CSS Grid Layout] Add GridSpan::iterator
Summary: [CSS Grid Layout] Add GridSpan::iterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-19 03:28 PDT by Manuel Rego Casasnovas
Modified: 2014-06-20 01:29 PDT (History)
10 users (show)

See Also:


Attachments
Patch (5.20 KB, patch)
2014-06-19 14:45 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff
Patch (5.44 KB, patch)
2014-06-19 16:22 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2014-06-19 03:28:42 PDT
Once GridResolvedPosition patch has landed (bug #131732) it'd be nice to refactor current loops to make them simpler.

This has been already implemented in Blink and should be ported into WebKit (see https://codereview.chromium.org/235663004/).
Comment 1 Manuel Rego Casasnovas 2014-06-19 14:45:03 PDT
Created attachment 233386 [details]
Patch

Small refactoring of GridResolvedPosition loops.
Comment 2 Bem Jones-Bey 2014-06-19 15:22:16 PDT
Comment on attachment 233386 [details]
Patch

Why can't you use a range based for loop?
Comment 3 Manuel Rego Casasnovas 2014-06-19 16:10:50 PDT
(In reply to comment #2)
> (From update of attachment 233386 [details])
> Why can't you use a range based for loop?

Good idea, I'm changing the patch to use them. Thanks for the suggestion.
Comment 4 Manuel Rego Casasnovas 2014-06-19 16:22:06 PDT
Created attachment 233392 [details]
Patch

New version using range-based for loops.
Comment 5 Bem Jones-Bey 2014-06-19 21:44:30 PDT
Comment on attachment 233392 [details]
Patch

iterators are awesome. r=me.
Comment 6 Manuel Rego Casasnovas 2014-06-20 01:29:30 PDT
Comment on attachment 233392 [details]
Patch

Clearing flags on attachment: 233392

Committed r170182: <http://trac.webkit.org/changeset/170182>
Comment 7 Manuel Rego Casasnovas 2014-06-20 01:29:38 PDT
All reviewed patches have been landed.  Closing bug.