WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134054
Move generate prototype and constructor classes into the generated implementation files
https://bugs.webkit.org/show_bug.cgi?id=134054
Summary
Move generate prototype and constructor classes into the generated implementa...
Sam Weinig
Reported
2014-06-18 18:39:44 PDT
Move generate prototype and constructor classes into the generated implementation files
Attachments
Patch
(170.42 KB, patch)
2014-06-18 19:22 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(171.31 KB, patch)
2014-06-18 22:26 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(175.97 KB, patch)
2014-06-19 12:04 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(181.46 KB, patch)
2014-06-19 13:51 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(184.05 KB, patch)
2014-06-19 15:55 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(184.41 KB, patch)
2014-06-19 16:12 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(184.79 KB, patch)
2014-06-19 16:21 PDT
,
Sam Weinig
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-06-18 19:22:41 PDT
Created
attachment 233347
[details]
Patch
WebKit Commit Bot
Comment 2
2014-06-18 19:24:58 PDT
Attachment 233347
[details]
did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:78: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:69: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:56: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:144: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp:95: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp:70: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:64: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:313: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 17 in 66 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2014-06-18 22:26:44 PDT
Created
attachment 233350
[details]
Patch
WebKit Commit Bot
Comment 4
2014-06-18 22:28:54 PDT
Attachment 233350
[details]
did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:78: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:69: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:56: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:144: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp:95: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp:70: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:64: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:313: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 17 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5
2014-06-19 12:04:25 PDT
Created
attachment 233372
[details]
Patch
WebKit Commit Bot
Comment 6
2014-06-19 12:06:13 PDT
Attachment 233372
[details]
did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:78: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:69: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:56: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:313: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:144: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:64: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp:95: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp:70: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 17 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 7
2014-06-19 13:51:58 PDT
Created
attachment 233379
[details]
Patch
WebKit Commit Bot
Comment 8
2014-06-19 13:53:01 PDT
Attachment 233379
[details]
did not pass style-queue: ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNondeterministic.cpp:78: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:69: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSattribute.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:56: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp:57: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:64: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp:313: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp:144: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4333: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/bindings/scripts/test/JS/JSreadonly.cpp:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:61: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp:58: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp:95: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp:70: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 18 in 79 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 9
2014-06-19 15:55:02 PDT
Created
attachment 233389
[details]
Patch
Sam Weinig
Comment 10
2014-06-19 16:12:10 PDT
Created
attachment 233390
[details]
Patch
Sam Weinig
Comment 11
2014-06-19 16:21:24 PDT
Created
attachment 233391
[details]
Patch
Sam Weinig
Comment 12
2014-06-19 16:43:01 PDT
Landed in
r170167
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug