Bug 134051 - [Cocoa] Modernize one-method authentication
Summary: [Cocoa] Modernize one-method authentication
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-18 17:13 PDT by mitz
Modified: 2014-06-18 17:31 PDT (History)
1 user (show)

See Also:

Attachments
Add -_webView:didReceiveAuthenticationChallenge:completionHandler: (9.86 KB, patch)
2014-06-18 17:19 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-18 17:13:53 PDT 
[Cocoa] Modernize one-method authentication
Comment 1 mitz 2014-06-18 17:19:54 PDT 
Created attachment 233342 [details]
Add -_webView:didReceiveAuthenticationChallenge:completionHandler:
Comment 2 WebKit Commit Bot 2014-06-18 17:22:24 PDT 
Attachment 233342 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:616:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-06-18 17:24:23 PDT 
Comment on attachment 233342 [details]
Add -_webView:didReceiveAuthenticationChallenge:completionHandler:

View in context: https://bugs.webkit.org/attachment.cgi?id=233342&action=review

> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:640
> +                    [NSException raise:NSInvalidArgumentException format:@"Invalid NSURLSessionAuthChallengeDisposition (%ld)", (long)disposition];

I think you should call checker->didCallCompletionHandler() before raising the exception here, otherwise you'll get another exception when the completionHandler is released.
Comment 4 mitz 2014-06-18 17:31:33 PDT 
Committed <http://trac.webkit.org/r170137>.