Bug 134050 – LayerPool’d PlatformCALayerRemote/RemoteLayerBackingStore can have stale context pointers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

Leading to horrible things when they are destroyed or displayed (and try to use said stale pointers).

<rdar://problem/17315114>

[Tim Horton]

Created attachment 233387 [details]
patch

[WebKit Commit Bot]

Attachment 233387 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/PlatformCALayer.h:228:  The parameter name "layerType" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/ca/PlatformCALayer.h:228:  The parameter name "client" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 233387 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233387&action=review

> Source/WebCore/platform/graphics/ca/PlatformCALayer.h:228
> +    PassRefPtr<PlatformCALayer> createCompatibleLayerWithSize(LayerType layerType, PlatformCALayerClient* client, IntSize, UseLayerPool = UseLayerPool::DoNotUse);

UseLayerPool::DoNotUse hurts.

Why not just have two create methods, one which tries the pool then calls the other?

[Tim Horton]

http://trac.webkit.org/changeset/170179