Bug 134022 – [Soup] Image Data URIs not displaying if media-type is not specified

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Platform

[Shanmuga Pandi M]

Created attachment 233299 [details]
Sample test file

On Webkit2 EFL port,

Steps to Reproduce:

1. Open attached sample html file.
2. Observe

Actual Result:
    Nothing is displayed.

Expected Result:
    One directory icon should get displayed


Firefox and chrome working as expected.

If Data-URI doesn't contain media-type, then ImageDecoder creation fails due to improper data it receives.

[Shanmuga Pandi M]

Created attachment 233301 [details]
Patch

[WebKit Commit Bot]

Attachment 233301 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Shanmuga Pandi M]

Created attachment 233303 [details]
Patch

[Dan Winship]

This seems like something that should be fixed in libsoup

[Shanmuga Pandi M]

(In reply to comment #4)
> This seems like something that should be fixed in libsoup


Yes. Can we push this patch until libsoup fixes this issue?

[Gustavo Noronha (kov)]

Perhaps you could patch libsoup instead? Shouldn't be much harder than fixing it here.

[Michael Catanzaro]

Comment on attachment 233303 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.

[Michael Catanzaro]

I see a directory icon, so I guess it's already been fixed.