WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134009
[iOS][WK2] Re-sync didCommitLoadForMainFrame with its corresponding tile update
https://bugs.webkit.org/show_bug.cgi?id=134009
Summary
[iOS][WK2] Re-sync didCommitLoadForMainFrame with its corresponding tile update
Benjamin Poulain
Reported
2014-06-17 17:25:57 PDT
[iOS][WK2] Re-sync didCommitLoadForMainFrame with its corresponding tile update
Attachments
Patch
(21.83 KB, patch)
2014-06-17 17:29 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Patch
(9.23 KB, patch)
2014-06-17 21:39 PDT
,
Benjamin Poulain
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-06-17 17:29:08 PDT
Created
attachment 233274
[details]
Patch
Benjamin Poulain
Comment 2
2014-06-17 17:29:40 PDT
<
rdar://problem/17352039
>
WebKit Commit Bot
Comment 3
2014-06-17 17:30:30 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See
http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Tim Horton
Comment 4
2014-06-17 17:45:37 PDT
Comment on
attachment 233274
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=233274&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:705 > +- (void)_didCommitLoadForMainFrameWithNextDrawingTransactionID:(uint64_t)nextDrawingTransactionID
The transaction IDs are for the whole commit, which includes layer tree updates, scrolling updates, render tree size, scale factors, etc. Maybe just "TransactionID", instead of Drawing-?
> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:281 > +void PageClientImpl::didCommitLoadForMainFrame(const String& /* mimeType */, bool /* useCustomContentProvider */, uint64_t /* nextDrawingTransactionID */)
I really don't think we should propagate this RemoteLayerTreeDrawingArea-specific thing through everywhere, but I'm not sure how else to do this.
Benjamin Poulain
Comment 5
2014-06-17 21:39:18 PDT
Created
attachment 233284
[details]
Patch
Tim Horton
Comment 6
2014-06-17 21:46:42 PDT
Comment on
attachment 233284
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=233284&action=review
> Source/WebKit2/ChangeLog:8 > + WKWebView assumed the first _didCommitLayerTree: after _didCommitLoadForMainFrame
extra space between 'assumed' and 'the'
> Source/WebKit2/ChangeLog:11 > + This is not always true. Sometimes, a set of tile can be rendered in the CoreAnimation thread
tile*s*, and it's not the CoreAnimation thread, it's our own layer flush thread (com.apple.WebKit.WebContent.RemoteLayerTreeDrawingArea.CommitQueue).
> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:708 > + _firstPaintAfterCommitLoadTransactionID = static_cast<WebKit::RemoteLayerTreeDrawingAreaProxy*>(_page->drawingArea())->nextLayerTreeIdTransactionID();
Don't we have toRemoteLayerTreeDrawingAreaProxy()? If not, maybe add the macros so we do?
> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:52 > + uint64_t nextLayerTreeIdTransactionID() const { return m_lastWillCommitLayerTreeTransactionID + 1; }
what's with the Id in the middle of this name? should just be nextLayerTreeTransactionID I think.
> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:96 > + uint64_t m_lastWillCommitLayerTreeTransactionID;
maybe this is m_pendingLayerTreeTransactionID?
Benjamin Poulain
Comment 7
2014-06-18 14:38:33 PDT
Committed
r170115
: <
http://trac.webkit.org/changeset/170115
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug