Fix error messages for incorrect hex literals
Created attachment 233259 [details] Patch
Comment on attachment 233259 [details] Patch r=me
Comment on attachment 233259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233259&action=review > Source/JavaScriptCore/parser/Lexer.cpp:1657 > + m_lexErrorMessage = "No space between hexadecimal literal and identifier"; Can we add a test for this new error message?
Comment on attachment 233259 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=233259&action=review > Source/JavaScriptCore/parser/ParserTokens.h:153 > + INVALID_HEX_NUMBER_ERRORTOK = 11 | ErrorTokenFlag For your consideration, I suggest that we add a trailing comma (,) to the end of this line so that we can avoid touching the last line of this enum (which creates noise when using svn/git blame) when adding a new enum value.
Committed r170079: <http://trac.webkit.org/changeset/170079>
(In reply to comment #5) > Committed r170079: <http://trac.webkit.org/changeset/170079> For completeness, this changeset includes an additional test case called, LayoutTests/js/parser-error-messages.html, that tests for the syntax error "No space between hexadecimal literal and identifier" and hence addresses comment #3.