WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133992
Remove unnecessary Structure flags from generated bindings
https://bugs.webkit.org/show_bug.cgi?id=133992
Summary
Remove unnecessary Structure flags from generated bindings
Sam Weinig
Reported
2014-06-17 12:42:00 PDT
Remove unnecessary Structure flags from generated bindings
Attachments
Patch
(24.67 KB, patch)
2014-06-17 12:45 PDT
,
Sam Weinig
dbates
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2014-06-17 12:45:32 PDT
Created
attachment 233252
[details]
Patch
Daniel Bates
Comment 2
2014-06-17 14:11:49 PDT
Comment on
attachment 233252
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=233252&action=review
This patch looks sane to me.
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4350 > + push(@$outputArray, "protected:\n");
Nit: This line should be indented such that the 'p' in "push" left aligned with the 'p' in "push" on the line below.
Sam Weinig
Comment 3
2014-06-17 14:50:56 PDT
Committed in
r170074
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug