Bug 133992 - Remove unnecessary Structure flags from generated bindings
Summary: Remove unnecessary Structure flags from generated bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-17 12:42 PDT by Sam Weinig
Modified: 2014-06-17 14:50 PDT (History)
12 users (show)

See Also:

Attachments
Patch (24.67 KB, patch)
2014-06-17 12:45 PDT, Sam Weinig 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-06-17 12:42:00 PDT 
Remove unnecessary Structure flags from generated bindings
Comment 1 Sam Weinig 2014-06-17 12:45:32 PDT 
Created attachment 233252 [details]
Patch
Comment 2 Daniel Bates 2014-06-17 14:11:49 PDT 
Comment on attachment 233252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233252&action=review

This patch looks sane to me.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4350
> +    push(@$outputArray, "protected:\n");

Nit: This line should be indented such that the 'p' in "push" left aligned with the 'p' in "push" on the line below.
Comment 3 Sam Weinig 2014-06-17 14:50:56 PDT 
Committed in r170074.