WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
133989
Only show telephone number highlights if only one number is selected
https://bugs.webkit.org/show_bug.cgi?id=133989
Summary
Only show telephone number highlights if only one number is selected
Brady Eidson
Reported
2014-06-17 11:51:10 PDT
Only show telephone number highlights if only one number is selected <
rdar://problem/16874568
>
Attachments
Patch v1
(13.63 KB, patch)
2014-06-17 12:03 PDT
,
Brady Eidson
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brady Eidson
Comment 1
2014-06-17 11:52:06 PDT
Also only while the mouse is over the phone number.
Brady Eidson
Comment 2
2014-06-17 12:03:30 PDT
Created
attachment 233246
[details]
Patch v1
Tim Horton
Comment 3
2014-06-17 12:07:21 PDT
Comment on
attachment 233246
[details]
Patch v1 View in context:
https://bugs.webkit.org/attachment.cgi?id=233246&action=review
> Source/WebKit2/WebProcess/WebPage/TelephoneNumberOverlayController.h:54 > DDHighlightRef highlight() const { return m_highlight.get(); }
Weird that this isn't in a mac/ subdirectory.
> Source/WebKit2/WebProcess/WebPage/TelephoneNumberOverlayController.h:56 > + bool hovered() const { return m_hovered; }
isHovered.
Brady Eidson
Comment 4
2014-06-17 12:18:30 PDT
http://trac.webkit.org/changeset/170067
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug