Bug 133989 - Only show telephone number highlights if only one number is selected
Summary: Only show telephone number highlights if only one number is selected
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-17 11:51 PDT by Brady Eidson
Modified: 2014-06-17 12:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch v1 (13.63 KB, patch)
2014-06-17 12:03 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-06-17 11:51:10 PDT 
Only show telephone number highlights if only one number is selected

<rdar://problem/16874568>
Comment 1 Brady Eidson 2014-06-17 11:52:06 PDT 
Also only while the mouse is over the phone number.
Comment 2 Brady Eidson 2014-06-17 12:03:30 PDT 
Created attachment 233246 [details]
Patch v1
Comment 3 Tim Horton 2014-06-17 12:07:21 PDT 
Comment on attachment 233246 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=233246&action=review

> Source/WebKit2/WebProcess/WebPage/TelephoneNumberOverlayController.h:54
>      DDHighlightRef highlight() const { return m_highlight.get(); }

Weird that this isn't in a mac/ subdirectory.

> Source/WebKit2/WebProcess/WebPage/TelephoneNumberOverlayController.h:56
> +    bool hovered() const { return m_hovered; }

isHovered.
Comment 4 Brady Eidson 2014-06-17 12:18:30 PDT 
http://trac.webkit.org/changeset/170067