Bug 133921 - invalidateCallbackMap doesn’t pass the error parameter on to invalidate(), so script completion handler is passed the wrong error
Summary: invalidateCallbackMap doesn’t pass the error parameter on to invalidate(), so...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-06-14 16:06 PDT by mitz
Modified: 2014-06-15 11:07 PDT (History)
7 users (show)

See Also:

Attachments
Patch (16.05 KB, patch)
2014-06-15 10:24 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-14 16:06:29 PDT 
invalidateCallbackMap in GenericCallback.h doesn’t pass its error parameter on to the callbacks’ invalidate function. Therefore the error passed into -[WKWebView evaluateJavaScript:completionHandler:]’s completion handler is always WKErrorUnknown, and the completion handler is called synchronously in the PageInvalidated case, even though it’s supposed to be deferred.
Comment 1 mitz 2014-06-14 16:08:25 PDT 
<rdar://problem/17316653>
Comment 2 Anders Carlsson 2014-06-15 10:24:07 PDT 
Created attachment 233141 [details]
Patch
Comment 3 Anders Carlsson 2014-06-15 11:07:36 PDT 
Committed r169990: <http://trac.webkit.org/changeset/169990>