Bug 133920 – Copy SharedBuffer data into IPC message directly

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Pratik Solanki]

When Data array callbacks are enabled, we currently merge all the CFDataRefs in SharedBuffer into one contiguous memory buffer before copying into the IPC message. We can avoid the merge into a single buffer here.

[Pratik Solanki]

Created attachment 233130 [details]
Patch

[Sam Weinig]

I don't think there is any reason to add a SharedBufferDataReference type. Instead, we should just add a coder for SharedBuffer.

[Build Bot]

Comment on attachment 233130 [details]
Patch

Attachment 233130 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4560879307718656

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233133 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Pratik Solanki]

(In reply to comment #3)
> (From update of attachment 233130 [details])
> Attachment 233130 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.appspot.com/results/4560879307718656
> 
> New failing tests:
> media/W3C/video/networkState/networkState_during_loadstart.html

Looks like a flaky test. I see these failures in other bugs as well so this is not related to my change.

[Pratik Solanki]

Comment on attachment 233130 [details]
Patch

Clearing flags on attachment: 233130

Committed r170154: <http://trac.webkit.org/changeset/170154>

[Pratik Solanki]

All reviewed patches have been landed.  Closing bug.