Bug 133909 - Get rid of GenericAPICallback
Summary: Get rid of GenericAPICallback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 12:57 PDT by mitz
Modified: 2014-06-14 16:12 PDT (History)
11 users (show)

See Also:

Attachments
Replace GenericAPICallback with genericCallbackFunction() (21.00 KB, patch)
2014-06-14 13:03 PDT, mitz 		sam: review+
mitz: commit-queue-
Details | Formatted Diff | Diff
Patch (22.69 KB, patch)
2014-06-14 14:36 PDT, mitz 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-06-14 12:57:50 PDT 
In preparation for passing callbacks as functions, replace GenericAPICallback::create, which returned a GenericCallback, with a function template that returns an appropriate callback function.
Comment 1 mitz 2014-06-14 13:03:59 PDT 
Created attachment 233116 [details]
Replace GenericAPICallback with genericCallbackFunction()
Comment 2 WebKit Commit Bot 2014-06-14 13:05:57 PDT 
Attachment 233116 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-06-14 14:36:07 PDT 
Created attachment 233123 [details]
Patch
Comment 4 WebKit Commit Bot 2014-06-14 14:36:54 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 WebKit Commit Bot 2014-06-14 14:37:04 PDT 
Attachment 233123 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/GenericCallback.h:174:  Extra space before [  [whitespace/braces] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 mitz 2014-06-14 16:12:24 PDT 
Committed <http://trac.webkit.org/r169984>.