Bug 133908 - Some classes with virtual methods are missing virtual destructors
Summary: Some classes with virtual methods are missing virtual destructors
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 12:17 PDT by Zan Dobersek
Modified: 2014-07-29 14:41 PDT (History)
17 users (show)

See Also:


Attachments
Patch (10.52 KB, patch)
2014-06-14 12:25 PDT, Zan Dobersek
andersca: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-06-14 12:17:54 PDT
Some classes with virtual methods are missing virtual destructors
Comment 1 Zan Dobersek 2014-06-14 12:25:40 PDT
Created attachment 233115 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-14 12:26:38 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Anders Carlsson 2014-06-14 17:35:58 PDT
Comment on attachment 233115 [details]
Patch

I don't think this warning is useful. Nobody deletes a TextureMapperPlatformLayer::Client for example, so this just creates extra vtable entries for no good reason.
Comment 4 Zan Dobersek 2014-07-29 14:41:53 PDT
-Wdelete-non-virtual-dtor only warns about cases where such classes are actually deleted.

There are no such warnings occurring with the current code, so there's nothing to do here.