Bug 133905 - operationCreateArguments could cause a GC during OSR exit
Summary: operationCreateArguments could cause a GC during OSR exit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 10:23 PDT by Michael Saboff
Modified: 2014-06-16 12:47 PDT (History)
0 users

See Also:

Attachments
Patch (5.94 KB, patch)
2014-06-14 10:32 PDT, Michael Saboff 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-06-14 10:23:49 PDT 
We should delay GC during createArguments when called from OSR exit stub.
Comment 1 Michael Saboff 2014-06-14 10:32:30 PDT 
Created attachment 233110 [details]
Patch
Comment 2 Michael Saboff 2014-06-14 10:44:41 PDT 
Committed r169973: <http://trac.webkit.org/changeset/169973>
Comment 3 Geoffrey Garen 2014-06-16 11:38:24 PDT 
Comment on attachment 233110 [details]
Patch

Why did you choose to special-case arguments recovery, rather than deferring GC throughout the OSR exit process?
Comment 4 Michael Saboff 2014-06-16 12:47:28 PDT 
(In reply to comment #3)
> (From update of attachment 233110 [details])
> Why did you choose to special-case arguments recovery, rather than deferring GC throughout the OSR exit process?

This was the only place that Mark H and I found where we callout and allocate an object.  Also, it seemed more error prone to create a JIT equivalent of DeferGCForAWhile to wrap an OSR exit stub.