Bug 133902 - Use references instead of pointers to RenderBlock in RenderObject::enclosingBox().
Summary: Use references instead of pointers to RenderBlock in RenderObject::enclosingB...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 08:46 PDT by Jeongeun Kim
Modified: 2014-06-16 12:52 PDT (History)
12 users (show)

See Also:

Attachments
Patch (15.09 KB, patch)
2014-06-14 08:54 PDT, Jeongeun Kim 		no flags Details | Formatted Diff | Diff
verification on win-ews (15.09 KB, patch)
2014-06-16 06:10 PDT, Jeongeun Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeongeun Kim 2014-06-14 08:46:07 PDT 
Use references instead of pointers to RenderBlock for return type of RenderObject::enclosingBox().
Just a straightforward conversion from pointers to references.
Comment 1 Jeongeun Kim 2014-06-14 08:54:30 PDT 
Created attachment 233108 [details]
Patch
Comment 2 Jeongeun Kim 2014-06-16 06:10:50 PDT 
Created attachment 233156 [details]
verification on win-ews
Comment 3 Jeongeun Kim 2014-06-16 08:37:58 PDT 
This patch is for removing "// FIXME: This should return a reference; it can always find the root RenderView." in RenderObject::enclosingBox().
Please take a look.
Thanks,
Jeongeun
Comment 4 WebKit Commit Bot 2014-06-16 12:52:51 PDT 
Comment on attachment 233156 [details]
verification on win-ews

Clearing flags on attachment: 233156

Committed r170024: <http://trac.webkit.org/changeset/170024>
Comment 5 WebKit Commit Bot 2014-06-16 12:52:56 PDT 
All reviewed patches have been landed.  Closing bug.