Bug 133897 – Make GenericCallback variadic

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

Make GenericCallback variadic

Created attachment 233104 [details]
Make GenericCallback variadic, get rid of legacy callback functions, etc.

Committed <http://trac.webkit.org/r169962>.

[Csaba Osztrogonác]

(In reply to comment #2)
> Committed <http://trac.webkit.org/r169962>.

It broke the GTK build:

../../Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp: In function ‘void webkitPrintOperationPrintPagesForFrame(WebKitPrintOperation*, WebKit::WebFrameProxy*, GtkPrintSettings*, GtkPageSetup*)’:
../../Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:279:6: error: no matching function for call to ‘WebKit::GenericCallback<API::Error*>::create(webkitPrintOperationPrintPagesForFrame(WebKitPrintOperation*, WebKit::WebFrameProxy*, GtkPrintSettings*, GtkPageSetup*)::__lambda3)’
     }));
      ^
../../Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:279:6: note: candidate is:
In file included from ../../Source/WebKit2/UIProcess/WebFrameProxy.h:31:0,
                 from ../../Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperationPrivate.h:24,
                 from ../../Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:23:
../../Source/WebKit2/UIProcess/GenericCallback.h:132:40: note: static WTF::PassRefPtr<WebKit::GenericCallback<T> > WebKit::GenericCallback<T>::create(WebKit::GenericCallback<T>::CallbackFunction) [with T = {API::Error*}; WebKit::GenericCallback<T>::CallbackFunction = std::function<void(API::Error*, WebKit::CallbackBase::Error)>]
     static PassRefPtr<GenericCallback> create(CallbackFunction callback)
                                        ^
../../Source/WebKit2/UIProcess/GenericCallback.h:132:40: note:   no known conversion for argument 1 from ‘webkitPrintOperationPrintPagesForFrame(WebKitPrintOperation*, WebKit::WebFrameProxy*, GtkPrintSettings*, GtkPageSetup*)::__lambda3’ to ‘WebKit::GenericCallback<API::Error*>::CallbackFunction {aka std::function<void(API::Error*, WebKit::CallbackBase::Error)>}’