Bug 133888 - Clean up layers in RemoteLayerTreeHost::clearLayers()
Summary: Clean up layers in RemoteLayerTreeHost::clearLayers()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Hock
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 16:03 PDT by Martin Hock
Modified: 2014-06-16 10:21 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.50 KB, patch)
2014-06-13 16:04 PDT, Martin Hock
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (505.54 KB, application/zip)
2014-06-13 17:03 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Hock 2014-06-13 16:03:28 PDT
Layers needed to be removed from their parent.
Comment 1 Martin Hock 2014-06-13 16:04:58 PDT
Created attachment 233085 [details]
patch
Comment 2 Tim Horton 2014-06-13 16:25:53 PDT
Comment on attachment 233085 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233085&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeHost.mm:35
> +#if PLATFORM(IOS)
> +#import <UIKit/UIView.h>
> +#endif

this belongs in its own block.
Comment 3 Build Bot 2014-06-13 17:03:45 PDT
Comment on attachment 233085 [details]
patch

Attachment 233085 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5916438497853440

New failing tests:
http/tests/appcache/404-manifest.html
Comment 4 Build Bot 2014-06-13 17:03:47 PDT
Created attachment 233093 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Martin Hock 2014-06-13 17:04:39 PDT
Committed r169957: <http://trac.webkit.org/changeset/169957>
Comment 6 Martin Hock 2014-06-16 10:21:42 PDT
The ML bot here seems to have passed with this commit included:

http://build.webkit.org/builders/Apple%20MountainLion%20Release%20WK2%20%28Tests%29/builds/19056