Bug 133880 - OSR exit should barrier the Executables for all InlineCallFrames, not just those on the stack at the time of exit
Summary: OSR exit should barrier the Executables for all InlineCallFrames, not just th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-13 13:57 PDT by Mark Hahnenberg
Modified: 2014-06-16 15:44 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.69 KB, patch)
2014-06-13 13:59 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-06-13 13:57:47 PDT
We could have exited due to a value received from an inlined block that's no longer on the stack, so we should just barrier all InlineCallFrames.
Comment 1 Mark Hahnenberg 2014-06-13 13:59:39 PDT
Created attachment 233073 [details]
Patch
Comment 2 WebKit Commit Bot 2014-06-13 15:19:22 PDT
Comment on attachment 233073 [details]
Patch

Clearing flags on attachment: 233073

Committed r169951: <http://trac.webkit.org/changeset/169951>
Comment 3 WebKit Commit Bot 2014-06-13 15:19:24 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Geoffrey Garen 2014-06-16 15:44:21 PDT
<rdar://problem/17276579>