Bug 133855 – [Gtk] [Stable] Fix the "Safari" part of the UA

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Sergio Villar Senin]

The part of our UA where we claim to be Safari is plainly wrong. Since version 3.0 the Safari user agent has the following structure:

Version/X Safari/Y

while in WebKitGtk that part looks like

Safari/Y Version/6.0

This is causing problems with lots of websites, some of them very important like live.com (hotmail.com) our www.icloud.com, that report "unsupported browser" problems.

This is basically a port of https://bugs.webkit.org/show_bug.cgi?id=133403

[Sergio Villar Senin]

Created attachment 233049 [details]
Patch

[Martin Robinson]

Comment on attachment 233049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233049&action=review

> Tools/TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:108
>      settings = webkit_web_view_get_settings(WEBKIT_WEB_VIEW(webView));
>      defaultUserAgent = g_strdup(webkit_web_settings_get_user_agent(settings));
>  
> +    g_assert(g_strstr_len(defaultUserAgent, -1, "Version/8.0 Safari/"));
> +    g_assert(g_strstr_len(defaultUserAgent, -1, "Version/8.0") < g_strstr_len(defaultUserAgent, -1, "Safari/"));
> +
>      test_non_quirky_user_agents(settings, defaultUserAgent);
>  
>      /* Test quirky google domains */

This file doesn't exist any longer. :)

[Sergio Villar Senin]

Comment on attachment 233049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=233049&action=review

>> Tools/TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c:108
>>      /* Test quirky google domains */
> 
> This file doesn't exist any longer. :)

It does in the stable branch. This is for stable only

[Martin Robinson]

Comment on attachment 233049 [details]
Patch

Doh! Sorry.

[Sergio Villar Senin]

Committed finally in r170009

[Sergio Villar Senin]

Comment on attachment 233049 [details]
Patch

Clearing the flag now that landed