W3C test importer does not currently detect W3C manual tests (names suffixed with -manual.htm). It classifies wrongly most of them as JS tests since they include testharness.js/testharnessreport.js links.
Created attachment 233047 [details] Patch
Created attachment 238106 [details] Patch
Created attachment 238108 [details] Patch
Created attachment 238160 [details] Adding missing reference_support_info field
Rebecca, what do you think?
(In reply to comment #5) > Rebecca, what do you think? AFAIK, the CSSWG tests do not make use of the -manual suffix. That may only exist over on the web-platform-tests repo. In CSS land, if it doesn't have a testharness link or a rel=match link, then it's a manual test. Also, the CSSWG has a metadata flag for manual tests, called 'interact'. For example: <meta name="flags" content="interact" /> See: http://testthewebforward.org/docs/test-templates.html#requirement-flags Just curious though, why would we ever want any manual tests to be imported into WebKit?
(In reply to comment #6) > (In reply to comment #5) > > Rebecca, what do you think? > > AFAIK, the CSSWG tests do not make use of the -manual suffix. That may only exist over on the web-platform-tests repo. In CSS land, if it doesn't have a testharness link or a rel=match link, then it's a manual test. Also, the CSSWG has a metadata flag for manual tests, called 'interact'. > > For example: > <meta name="flags" content="interact" /> Thanks for that information. At some point, it should be good for all W3C test suites to be consistent with that respect. I will send a mail to public-test-infra@w3.org > See: > > http://testthewebforward.org/docs/test-templates.html#requirement-flags > > > Just curious though, why would we ever want any manual tests to be imported into WebKit? Purpose of this patch is actually to avoid manual test import. To do so, we need to correctly identify them. Applying CSS rules on WPT leads to importing WPT manual tests. The same applies to ref tests: in WPT, not all ref tests have a <link rel="match">.
Created attachment 238521 [details] Improved readability and added a unit test
Comment on attachment 238521 [details] Improved readability and added a unit test r=me
Comment on attachment 238521 [details] Improved readability and added a unit test Clearing flags on attachment: 238521 Committed r173880: <http://trac.webkit.org/changeset/173880>
All reviewed patches have been landed. Closing bug.