RESOLVED FIXED 133852
W3C test importer should detect manual and reference tests according their filenames 
https://bugs.webkit.org/show_bug.cgi?id=133852
Summary W3C test importer should detect manual and reference tests according their fi...
youenn fablet
Reported 2014-06-13 06:56:02 PDT
W3C test importer does not currently detect W3C manual tests (names suffixed with -manual.htm). It classifies wrongly most of them as JS tests since they include testharness.js/testharnessreport.js links.
Attachments
Patch (3.13 KB, patch)
2014-06-13 07:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2014-09-15 02:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (3.93 KB, patch)
2014-09-15 02:46 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Adding missing reference_support_info field (3.93 KB, patch)
2014-09-16 01:47 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Improved readability and added a unit test (4.86 KB, patch)
2014-09-23 01:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2014-06-13 07:07:38 PDT
Created attachment 233047 [details] Patch
youenn fablet
Comment 2 2014-09-15 02:29:24 PDT
Created attachment 238106 [details] Patch
youenn fablet
Comment 3 2014-09-15 02:46:01 PDT
Created attachment 238108 [details] Patch
youenn fablet
Comment 4 2014-09-16 01:47:57 PDT
Created attachment 238160 [details] Adding missing reference_support_info field
Bem Jones-Bey
Comment 5 2014-09-22 10:40:31 PDT
Rebecca, what do you think?
Rebecca Hauck
Comment 6 2014-09-22 11:01:20 PDT
(In reply to comment #5) > Rebecca, what do you think? AFAIK, the CSSWG tests do not make use of the -manual suffix. That may only exist over on the web-platform-tests repo. In CSS land, if it doesn't have a testharness link or a rel=match link, then it's a manual test. Also, the CSSWG has a metadata flag for manual tests, called 'interact'. For example: <meta name="flags" content="interact" /> See: http://testthewebforward.org/docs/test-templates.html#requirement-flags Just curious though, why would we ever want any manual tests to be imported into WebKit?
youenn fablet
Comment 7 2014-09-22 12:43:43 PDT
(In reply to comment #6) > (In reply to comment #5) > > Rebecca, what do you think? > > AFAIK, the CSSWG tests do not make use of the -manual suffix. That may only exist over on the web-platform-tests repo. In CSS land, if it doesn't have a testharness link or a rel=match link, then it's a manual test. Also, the CSSWG has a metadata flag for manual tests, called 'interact'. > > For example: > <meta name="flags" content="interact" /> Thanks for that information. At some point, it should be good for all W3C test suites to be consistent with that respect. I will send a mail to public-test-infra@w3.org > See: > > http://testthewebforward.org/docs/test-templates.html#requirement-flags > > > Just curious though, why would we ever want any manual tests to be imported into WebKit? Purpose of this patch is actually to avoid manual test import. To do so, we need to correctly identify them. Applying CSS rules on WPT leads to importing WPT manual tests. The same applies to ref tests: in WPT, not all ref tests have a <link rel="match">.
youenn fablet
Comment 8 2014-09-23 01:16:29 PDT
Created attachment 238521 [details] Improved readability and added a unit test
Bem Jones-Bey
Comment 9 2014-09-23 10:34:04 PDT
Comment on attachment 238521 [details] Improved readability and added a unit test r=me
WebKit Commit Bot
Comment 10 2014-09-23 11:09:08 PDT
Comment on attachment 238521 [details] Improved readability and added a unit test Clearing flags on attachment: 238521 Committed r173880: <http://trac.webkit.org/changeset/173880>
WebKit Commit Bot
Comment 11 2014-09-23 11:09:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.